Improve UI Indication for Unsaved Changes in Tabs#2568
Draft
schneidermic0 wants to merge 1 commit intoeclipse-platform:masterfrom
Draft
Improve UI Indication for Unsaved Changes in Tabs#2568schneidermic0 wants to merge 1 commit intoeclipse-platform:masterfrom
schneidermic0 wants to merge 1 commit intoeclipse-platform:masterfrom
Conversation
Author
|
Build errors are caused by dependency to eclipse-platform/eclipse.platform.swt#1632 |
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Contributor
schneidermic0
force-pushed
the
featute/new-dirty-indicator
branch
2 times, most recently
from
062378a to
2bc5d37
Compare
Tabs render dirty parts by showing a `*` in front of the tab name (e.g., in front of the file name. This information is hard to see by developers. This change introduces a graphical indicator on the close button to highlight dirty (unsaved) changes. Furthermore, introduction of a new preference "Indicate unsaved changes by overlaying the close button" in section "Appearance". If preference "Indicate unsaved changes by overlaying the close button" is set and there are unsaved changes in the editor, the "dirty" indicator overlays the close button. If the preference is not set (which is the default), the old behavior is in place which indicates unsaved changes by character `*`.
schneidermic0
force-pushed
the
featute/new-dirty-indicator
branch
from
2bc5d37 to
459aeca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables the indication for unsaved changes in tabs as described in eclipse-platform/eclipse.platform.swt#1632.
This PR depends on eclipse-platform/eclipse.platform.swt#1632 and must not be merged before eclipse-platform/eclipse.platform.swt#1632 is merged.
Tasks